儲存庫 vbox 的更動 26084

時間撮記:

2010-1-28 下午01:59:20 (15 年 以前)

作者:

vboxsync

svn:sync-xref-src-repo-rev:

57037

訊息:

Main: fix locking order violation when loading USB filters

檔案:

• trunk/src/VBox/Main/USBControllerImpl.cpp (修改) (2 筆差異)

trunk/src/VBox/Main/USBControllerImpl.cpp

@@ -611 +611 @@
  *  @param aMachineNode <Machine> node.
  *
- *  @note Locks this object for writing.
+ *  @note Does not lock "this" as Machine::loadHardware, which calls this, does not lock either.
  */
 HRESULT USBController::loadSettings(const settings::USBController &data)
@@ -617 +617 @@
     AutoCaller autoCaller(this);
     AssertComRCReturnRC(autoCaller.rc());
-
-    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
     /* Note: we assume that the default values for attributes of optional