vbox的更動 33736 路徑 trunk/src/VBox/Runtime/r0drv

時間撮記:

2010-11-3 下午04:30:23 (14 年 以前)

作者:

vboxsync

訊息:

semeventwait-r0drv-solaris.h: Disabled deadlocking fallback code.

檔案:

• trunk/src/VBox/Runtime/r0drv/solaris/semeventwait-r0drv-solaris.h (修改) (11 筆差異)

trunk/src/VBox/Runtime/r0drv/solaris/semeventwait-r0drv-solaris.h

@@ -70 +70 @@
     /** The thread to wake up. */
     kthread_t      *pThread;
+#if 0 /* @bugref{5342} */
     /** Cylic timer ID (used by the timeout callback). */
     cyclic_id_t     idCy;
+#endif
     /** The mutex associated with the condition variable wait. */
     void volatile  *pvMtx;
@@ -133 +135 @@
     {
         pWait->fIndefinite      = false;
-        if (   (fFlags & (RTSEMWAIT_FLAGS_NANOSECS | RTSEMWAIT_FLAGS_ABSOLUTE))
-            || pWait->cNsRelTimeout < UINT32_C(1000000000) / 100 /*Hz*/ * 4)
+        if (  (   (fFlags & (RTSEMWAIT_FLAGS_NANOSECS | RTSEMWAIT_FLAGS_ABSOLUTE))
+               || pWait->cNsRelTimeout < UINT32_C(1000000000) / 100 /*Hz*/ * 4)
+            && g_pfnrtR0Sol_timeout_generic != NULL /* See @bugref{5342} */)
             pWait->fHighRes     = true;
         else
@@ -163 +166 @@
     pWait->pThread          = curthread;
     pWait->pvMtx            = NULL;
+#if 0 /* @bugref{5342} */
     pWait->idCy             = CYCLIC_NONE;
+#endif
 
     return VINF_SUCCESS;
@@ -169 +174 @@
 
 
+#if 0 /* @bugref{5342} */
 /**
  * Cyclic timeout callback that sets the timeout indicator and wakes up the
@@ -185 +191 @@
            before we wake it up.
            Note: Trying to take the cpu_lock here doesn't work. */
+        /** @todo LOCK ORDER INVERSION (pMtx & cpu_lock when arming the timer, here it's inverted).
+         *  Possible fix: Use the thread lock for sleep/wakeup race prevention
+         *  instead of the mutex associated with the cv/event. */
         mutex_enter(pMtx);
         if (mutex_owner(&cpu_lock) == curthread)
@@ -196 +205 @@
     }
 }
+#endif
 
 
@@ -247 +257 @@
         if (pWait->fHighRes)
         {
+#if 0 /* @bugref{5342} */
             if (g_pfnrtR0Sol_timeout_generic != NULL)
+#endif
             {
                 /*
@@ -257 +269 @@
                                                       CALLOUT_FLAG_ABSOLUTE);
             }
+#if 0 /* @bugref{5342} */
             else
             {
@@ -276 +289 @@
                 mutex_exit(&cpu_lock);
             }
+#endif
         }
         else
@@ -318 +332 @@
         if (pWait->fHighRes)
         {
+#if 0 /* @bugref{5342} */
             if (g_pfnrtR0Sol_timeout_generic != NULL)
+#endif
                 g_pfnrtR0Sol_untimeout_generic(u.idCo, 0 /*nowait*/);
+#if 0 /* @bugref{5342} */
             else
             {
@@ -330 +347 @@
                 mutex_exit(&cpu_lock);
             }
+#endif
         }
         else