儲存庫 vbox 的更動 49078

時間撮記:

2013-10-14 上午02:28:52 (11 年 以前)

作者:

vboxsync

訊息:

dir-win.cpp/RTDirCreate: Aaaaaaaaaaaaaaaaarg!!!!!!!!!!

檔案:

• trunk/src/VBox/Runtime/r3/win/dir-win.cpp (修改) (1 筆差異)

trunk/src/VBox/Runtime/r3/win/dir-win.cpp

@@ -73 +73 @@
              * Turn off indexing of directory through Windows Indexing Service
              */
-            if (RT_SUCCESS(rc))
+            /** @todo This FILE_ATTRIBUTE_NOT_CONTENT_INDEXED hack (for .VDI files,
+             *        really) may cause failures on samba shares.  That really sweet and
+             *        need to be addressed differently.  We shouldn't be doing this
+             *        unless the caller actually asks for it, must less returning failure,
+             *        for crying out loud!  This is only important a couple of places in
+             *        main, if important is the right way to put it... */
+            if (   RT_SUCCESS(rc)
+                && !(fCreate & RTDIRCREATE_FLAGS_NOT_CONTENT_INDEXED_DONT_SET))
             {
-                if (SetFileAttributesW((LPCWSTR)pwszString, FILE_ATTRIBUTE_NOT_CONTENT_INDEXED))
+                if (   SetFileAttributesW((LPCWSTR)pwszString, FILE_ATTRIBUTE_NOT_CONTENT_INDEXED)
+                    || (fCreate & RTDIRCREATE_FLAGS_NOT_CONTENT_INDEXED_NOT_CRITICAL) )
                     rc = VINF_SUCCESS;
                 else