儲存庫 vbox 的更動 62614

時間撮記:

2016-7-28 上午10:40:46 (8 年 以前)

作者:

vboxsync

訊息:

hdaRegWriteSDCTL: Todo about IN_RING3/VINF_IOM_R3_MMIO_WRITE mess that the author needs cleaning up ASAP.

檔案:

• trunk/src/VBox/Devices/Audio/DevIchHda.cpp (修改) (11 筆差異)

trunk/src/VBox/Devices/Audio/DevIchHda.cpp

@@ -2016 +2016 @@
 static int hdaRegReadUnimpl(PHDASTATE pThis, uint32_t iReg, uint32_t *pu32Value)
 {
+    RT_NOREF_PV(pThis); RT_NOREF_PV(iReg);
     *pu32Value = 0;
     return VINF_SUCCESS;
@@ -2022 +2023 @@
 static int hdaRegWriteUnimpl(PHDASTATE pThis, uint32_t iReg, uint32_t u32Value)
 {
+    RT_NOREF_PV(pThis); RT_NOREF_PV(iReg); RT_NOREF_PV(u32Value);
     return VINF_SUCCESS;
 }
@@ -2084 +2086 @@
 static int hdaRegWriteGCTL(PHDASTATE pThis, uint32_t iReg, uint32_t u32Value)
 {
+    RT_NOREF_PV(iReg);
+
     if (u32Value & HDA_REG_FIELD_FLAG_MASK(GCTL, RST))
     {
@@ -2134 +2138 @@
 static int hdaRegReadINTSTS(PHDASTATE pThis, uint32_t iReg, uint32_t *pu32Value)
 {
+    RT_NOREF_PV(iReg);
+
     uint32_t v = 0;
     if (   HDA_REG_FLAG_VALUE(pThis, RIRBSTS, RIRBOIS)
@@ -2188 +2194 @@
 static int hdaRegReadWALCLK(PHDASTATE pThis, uint32_t iReg, uint32_t *pu32Value)
 {
+    RT_NOREF_PV(iReg);
+
     /* HDA spec (1a): 3.3.16 WALCLK counter ticks with 24Mhz bitclock rate. */
     *pu32Value = (uint32_t)ASMMultU64ByU32DivByU32(PDMDevHlpTMTimeVirtGetNano(pThis->CTX_SUFF(pDevIns))
@@ -2197 +2205 @@
 static int hdaRegReadSSYNC(PHDASTATE pThis, uint32_t iReg, uint32_t *pu32Value)
 {
+    RT_NOREF_PV(iReg);
+
     /* HDA spec (1a): 3.3.16 WALCLK counter ticks with 24Mhz bitclock rate. */
     *pu32Value = HDA_REG(pThis, SSYNC);
@@ -2211 +2221 @@
 static int hdaRegWriteCORBRP(PHDASTATE pThis, uint32_t iReg, uint32_t u32Value)
 {
+    RT_NOREF_PV(iReg);
+
     if (u32Value & HDA_REG_FIELD_FLAG_MASK(CORBRP, RST))
     {
@@ -2234 +2246 @@
     return rc;
 #else
+    RT_NOREF_PV(pThis); RT_NOREF_PV(iReg); RT_NOREF_PV(u32Value);
     return VINF_IOM_R3_MMIO_WRITE;
 #endif
@@ -2259 +2272 @@
     return rc;
 #else  /* !IN_RING3 */
+    RT_NOREF_PV(pThis); RT_NOREF_PV(iReg); RT_NOREF_PV(u32Value);
     return VINF_IOM_R3_MMIO_WRITE;
 #endif /* IN_RING3 */
@@ -2293 +2307 @@
     return VINF_SUCCESS; /* Always return success to the MMIO handler. */
 #else  /* !IN_RING3 */
+    RT_NOREF_PV(pThis); RT_NOREF_PV(iReg); RT_NOREF_PV(u32Value);
     return VINF_IOM_R3_MMIO_WRITE;
 #endif /* IN_RING3 */
@@ -2325 +2340 @@
         return hdaRegWriteU24(pThis, iReg, u32Value);
     }
+
+
+
+/** @todo r=bird: Andy, the spotty IN_RING3 in the rest of this function makes
+ *        little sense.  If you need to request a lock in ring-3, why don't
+ *        you need it in ring-0 / RC?  Or, reversely, why can you do the
+ *        fInReset handling without locking and resolving pStream in R0+RC
+ *        but not in ring-3?
+ *
+ *        What makes the least sense, is that you do fInReset +
+ *        hdaProcessInterrupt in R0/RC and then unconditionally forces a trip to
+ *        ring-3 and does the same again.
+ *
+ *        Please, do make up your mind what you want to do here ASAP!
+ */
+
 
 #ifdef IN_RING3