儲存庫 vbox 的更動 62647

時間撮記:

2016-7-28 下午10:02:27 (8 年 以前)

作者:

vboxsync

訊息:

VMMR3: warnings

位置:

trunk/src/VBox/VMM/VMMR3

檔案:

• CSAM.cpp (修改) (5 筆差異)
• HM.cpp (修改) (2 筆差異)
• VM.cpp (修改) (3 筆差異)
• VMEmt.cpp (修改) (1 筆差異)
• VMM.cpp (修改) (1 筆差異)
• VMMTests.cpp (修改) (2 筆差異)
• VMReq.cpp (修改) (6 筆差異)

trunk/src/VBox/VMM/VMMR3/CSAM.cpp

@@ -2271 +2271 @@
     Log(("CSAMR3UnmonitorPage %RRv %d\n", pPageAddrGC, enmTag));
 
-    Assert(enmTag == CSAM_TAG_REM);
+    Assert(enmTag == CSAM_TAG_REM); RT_NOREF_PV(enmTag);
 
 #ifdef VBOX_STRICT
@@ -2346 +2346 @@
 }
 
+#if 0 /* Unused */
 /**
  * Callback for delayed writes from non-EMT threads
@@ -2358 +2359 @@
     AssertRC(rc);
 }
+#endif
 
 /**
@@ -2372 +2374 @@
 static DECLCALLBACK(int) csamR3CodePageInvalidate(PVM pVM, PVMCPU pVCpu, RTGCPTR GCPtr, void *pvUser)
 {
+    RT_NOREF2(pVCpu, pvUser);
+
     g_fInCsamR3CodePageInvalidate = true;
     LogFlow(("csamR3CodePageInvalidate %RGv\n", GCPtr));
@@ -2377 +2381 @@
     csamFlushPage(pVM, GCPtr, false /* don't remove page! */);
     g_fInCsamR3CodePageInvalidate = false;
+
     return VINF_SUCCESS;
 }

trunk/src/VBox/VMM/VMMR3/HM.cpp

@@ -1775 +1775 @@
 VMMR3_INT_DECL(void) HMR3PagingModeChanged(PVM pVM, PVMCPU pVCpu, PGMMODE enmShadowMode, PGMMODE enmGuestMode)
 {
+    RT_NOREF_PV(pVM);
+
     /* Ignore page mode changes during state loading. */
     if (VMR3GetState(pVCpu->pVMR3) == VMSTATE_LOADING)
@@ -2041 +2043 @@
 {
     Log(("HMR3DisablePatching %RGv size %x\n", pPatchMem, cbPatchMem));
+    RT_NOREF2(pPatchMem, cbPatchMem);
 
     Assert(pVM->hm.s.pGuestPatchMem == pPatchMem);

trunk/src/VBox/VMM/VMMR3/VM.cpp

@@ -2713 +2713 @@
     int rc = PGMR3CheckIntegrity(pVM);
     AssertReleaseRC(rc);
+#else
+    RT_NOREF_PV(pVM);
 #endif
 }
@@ -3260 +3262 @@
 static bool vmR3ValidateStateTransition(VMSTATE enmStateOld, VMSTATE enmStateNew)
 {
-#ifdef VBOX_STRICT
+#ifndef VBOX_STRICT
+    RT_NOREF2(enmStateOld, enmStateNew);
+#else
     switch (enmStateOld)
     {
@@ -3531 +3535 @@
     RTCritSectEnter(&pUVM->vm.s.AtStateCritSect);
 
+    RT_NOREF_PV(enmStateOld);
     AssertMsg(pVM->enmVMState == enmStateOld,
               ("%s != %s\n", VMR3GetStateName(pVM->enmVMState), VMR3GetStateName(enmStateOld)));

trunk/src/VBox/VMM/VMMR3/VMEmt.cpp

@@ -68 +68 @@
  *
  * @returns Thread exit code.
- * @param   ThreadSelf  The handle to the executing thread.
+ * @param   hThreadSelf The handle to the executing thread.
  * @param   pUVCpu      Pointer to the user mode per-VCpu structure.
  * @param   idCpu       The virtual CPU ID, for backtrace purposes.
  */
-int vmR3EmulationThreadWithId(RTTHREAD ThreadSelf, PUVMCPU pUVCpu, VMCPUID idCpu)
+int vmR3EmulationThreadWithId(RTTHREAD hThreadSelf, PUVMCPU pUVCpu, VMCPUID idCpu)
 {
     PUVM    pUVM = pUVCpu->pUVM;
     int     rc;
+    RT_NOREF_PV(hThreadSelf);
 
     AssertReleaseMsg(VALID_PTR(pUVM) && pUVM->u32Magic == UVM_MAGIC,

trunk/src/VBox/VMM/VMMR3/VMM.cpp

@@ -446 +446 @@
 static void vmmR3InitRegisterStats(PVM pVM)
 {
+    RT_NOREF_PV(pVM);
+
     /*
      * Statistics.

trunk/src/VBox/VMM/VMMR3/VMMTests.cpp

@@ -559 +559 @@
         RTPrintf("VMM: profiling switcher...\n");
         Log(("VMM: profiling switcher...\n"));
-        uint64_t TickMin = ~0;
+        uint64_t TickMin = UINT64_MAX;
         tsBegin = RTTimeNanoTS();
         TickStart = ASMReadTSC();
@@ -701 +701 @@
         RTPrintf("VMM: profiling switcher...\n");
         Log(("VMM: profiling switcher...\n"));
-        uint64_t TickMin = ~0;
+        uint64_t TickMin = UINT64_MAX;
         uint64_t tsBegin = RTTimeNanoTS();
         uint64_t TickStart = ASMReadTSC();

trunk/src/VBox/VMM/VMMR3/VMReq.cpp

@@ -41 +41 @@
 *   Internal Functions                                                                                                           *
 *********************************************************************************************************************************/
-static int  vmR3ReqProcessOneU(PUVM pUVM, PVMREQ pReq);
+static int  vmR3ReqProcessOne(PVMREQ pReq);
 
 
@@ -941 +941 @@
          */
         pReq->enmState = VMREQSTATE_QUEUED;
-        rc = vmR3ReqProcessOneU(pUVM, pReq);
+        rc = vmR3ReqProcessOne(pReq);
         LogFlow(("VMR3ReqQueue: returns %Rrc (processed)\n", rc));
     }
@@ -1168 +1168 @@
          */
         STAM_COUNTER_INC(&pUVM->vm.s.StatReqProcessed);
-        int rc2 = vmR3ReqProcessOneU(pUVM, pReq);
+        int rc2 = vmR3ReqProcessOne(pReq);
         if (    rc2 >= VINF_EM_FIRST
             &&  rc2 <= VINF_EM_LAST)
@@ -1187 +1187 @@
  * @returns VBox status code.
  *
- * @param   pUVM        The user mode VM structure.
  * @param   pReq        Request packet to process.
  */
-static int  vmR3ReqProcessOneU(PUVM pUVM, PVMREQ pReq)
-{
-    LogFlow(("vmR3ReqProcessOneU: pReq=%p type=%d fFlags=%#x\n", pReq, pReq->enmType, pReq->fFlags));
+static int  vmR3ReqProcessOne(PVMREQ pReq)
+{
+    LogFlow(("vmR3ReqProcessOne: pReq=%p type=%d fFlags=%#x\n", pReq, pReq->enmType, pReq->fFlags));
 
     /*
@@ -1312 +1311 @@
     {
         /* Free the packet, nobody is waiting. */
-        LogFlow(("vmR3ReqProcessOneU: Completed request %p: rcReq=%Rrc rcRet=%Rrc - freeing it\n",
+        LogFlow(("vmR3ReqProcessOne: Completed request %p: rcReq=%Rrc rcRet=%Rrc - freeing it\n",
                  pReq, rcReq, rcRet));
         VMR3ReqFree(pReq);
@@ -1319 +1318 @@
     {
         /* Notify the waiter and him free up the packet. */
-        LogFlow(("vmR3ReqProcessOneU: Completed request %p: rcReq=%Rrc rcRet=%Rrc - notifying waiting thread\n",
+        LogFlow(("vmR3ReqProcessOne: Completed request %p: rcReq=%Rrc rcRet=%Rrc - notifying waiting thread\n",
                  pReq, rcReq, rcRet));
         ASMAtomicXchgSize(&pReq->fEventSemClear, false);