vbox的更動 62838 路徑 trunk/src/VBox/Debugger

時間撮記:

2016-8-1 下午05:01:57 (8 年 以前)

作者:

vboxsync

訊息:

Debugger: warnings

位置:

trunk/src/VBox/Debugger

檔案:

• DBGCBuiltInSymbols.cpp (修改) (1 筆差異)
• DBGCCmdHlp.cpp (修改) (2 筆差異)
• DBGCCommands.cpp (修改) (8 筆差異)
• DBGCEmulateCodeView.cpp (修改) (18 筆差異)
• DBGCEval.cpp (修改) (2 筆差異)
• DBGCOps.cpp (修改) (9 筆差異)
• DBGCTcp.cpp (修改) (1 筆差異)
• DBGPlugInDarwin.cpp (修改) (7 筆差異)

trunk/src/VBox/Debugger/DBGCBuiltInSymbols.cpp

@@ -36 +36 @@
 {
     /** @todo externally registered symbols. */
-    NOREF(pDbgc);
+    RT_NOREF2(pDbgc, pszSymbol);
     return NULL;
 }

trunk/src/VBox/Debugger/DBGCCmdHlp.cpp

@@ -791 +791 @@
 static DECLCALLBACK(int) dbgcHlpVarFromDbgfAddr(PDBGCCMDHLP pCmdHlp, PCDBGFADDRESS pAddress, PDBGCVAR pResult)
 {
+    RT_NOREF1(pCmdHlp);
     AssertPtrReturn(pAddress, VERR_INVALID_POINTER);
     AssertReturn(DBGFADDRESS_IS_VALID(pAddress), VERR_INVALID_PARAMETER);
@@ -913 +914 @@
                                             uint64_t *pcbRange)
 {
+    RT_NOREF1(pCmdHlp);
 /** @todo implement this properly, strings/symbols are not resolved now. */
     switch (pVar->enmRangeType)

trunk/src/VBox/Debugger/DBGCCommands.cpp

@@ -591 +591 @@
                                       const char *pszDescFmt, ...)
 {
+    RT_NOREF1(pDbgc);
     if (pszDescFmt)
     {
@@ -629 +630 @@
                                        const char *pszDescFmt, ...)
 {
+    RT_NOREF1(pDbgc);
     if (pszDescFmt)
     {
@@ -668 +670 @@
 static void dbgcCmdHelpOperators(PDBGC pDbgc, PDBGCCMDHLP pCmdHlp, uint32_t *pcHits)
 {
+    RT_NOREF1(pDbgc);
     DBGCCmdHlpPrintf(pCmdHlp, !*pcHits ? "Operators:\n" : "\nOperators:\n");
     *pcHits += 1;
@@ -706 +709 @@
 static void dbgcCmdHelpSummary(PDBGC pDbgc, PDBGCCMDHLP pCmdHlp, uint32_t *pcHits)
 {
+    RT_NOREF1(pDbgc);
     *pcHits += 1;
     DBGCCmdHlpPrintf(pCmdHlp,
@@ -903 +907 @@
 static DECLCALLBACK(int) dbgcCmdRunScript(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
+    RT_NOREF2(pUVM, pCmd);
+
     /* check that the parser did what it's supposed to do. */
     if (    cArgs != 1
@@ -1152 +1158 @@
 static DECLCALLBACK(int) dbgcCmdLogFlush(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
+    RT_NOREF3(pCmdHlp, pUVM, paArgs);
+
     RTLogFlush(NULL);
     PRTLOGGER pLogRel = RTLogRelGetDefaultInstance();
@@ -1685 +1693 @@
 static DECLCALLBACK(int) dbgcCmdLoadPlugIn(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
+    RT_NOREF1(pUVM);
     PDBGC pDbgc = DBGC_CMDHLP2DBGC(pCmdHlp);
 
@@ -1717 +1726 @@
 static DECLCALLBACK(int) dbgcCmdUnloadPlugIn(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
+    RT_NOREF1(pUVM);
     PDBGC pDbgc = DBGC_CMDHLP2DBGC(pCmdHlp);
 

trunk/src/VBox/Debugger/DBGCEmulateCodeView.cpp

@@ -660 +660 @@
      */
     uint64_t iHitTrigger = 0;
-    uint64_t iHitDisable = ~0;
+    uint64_t iHitDisable = UINT64_MAX;
     const char *pszCmds = NULL;
     unsigned iArg = 3;
@@ -1001 +1001 @@
      */
     uint64_t iHitTrigger = 0;
-    uint64_t iHitDisable = ~0;
+    uint64_t iHitDisable = UINT64_MAX;
     const char *pszCmds = NULL;
     unsigned iArg = 1;
@@ -1061 +1061 @@
      */
     uint64_t iHitTrigger = 0;
-    uint64_t iHitDisable = ~0;
+    uint64_t iHitDisable = UINT64_MAX;
     const char *pszCmds = NULL;
     unsigned iArg = 1;
@@ -2820 +2820 @@
      */
     unsigned    iEntry = ~0U;           /* The page directory index. ~0U for 'dpta'. */
-    DBGCVAR     VarGCPtr;               /* The GC address corresponding to the current PDE (iEntry != ~0U). */
+    DBGCVAR     VarGCPtr = { NULL, };   /* The GC address corresponding to the current PDE (iEntry != ~0U). */
     DBGCVAR     VarPDEAddr;             /* The address of the current PDE. */
     unsigned    cEntries;               /* The number of entries to display. */
@@ -3727 +3727 @@
 static DECLCALLBACK(int) dbgcCmdDumpTypeInfo(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
-    PDBGC pDbgc = DBGC_CMDHLP2DBGC(pCmdHlp);
-    int   rc;
-
     DBGC_CMDHLP_REQ_UVM_RET(pCmdHlp, pCmd, pUVM);
     DBGC_CMDHLP_ASSERT_PARSER_RET(pCmdHlp, pCmd, 0, cArgs == 1 || cArgs == 2);
@@ -3849 +3846 @@
 static DECLCALLBACK(int) dbgcCmdDumpTypedVal(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
-    PDBGC pDbgc = DBGC_CMDHLP2DBGC(pCmdHlp);
-    int   rc;
-
     DBGC_CMDHLP_REQ_UVM_RET(pCmdHlp, pCmd, pUVM);
     DBGC_CMDHLP_ASSERT_PARSER_RET(pCmdHlp, pCmd, 0, cArgs == 2 || cArgs == 3);
@@ -3863 +3857 @@
      */
     DBGFADDRESS Address;
-    rc = pCmdHlp->pfnVarToDbgfAddr(pCmdHlp, &paArgs[1], &Address);
+    int rc = pCmdHlp->pfnVarToDbgfAddr(pCmdHlp, &paArgs[1], &Address);
     if (RT_FAILURE(rc))
         return pCmdHlp->pfnVBoxError(pCmdHlp, rc, "VarToDbgfAddr(,%Dv,)\n", &paArgs[1]);
@@ -4025 +4019 @@
 static DECLCALLBACK(int) dbgcCmdEditMem(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
-    PDBGC pDbgc = DBGC_CMDHLP2DBGC(pCmdHlp);
-    unsigned iArg;
-
     /*
      * Validate input.
@@ -4033 +4024 @@
     DBGC_CMDHLP_ASSERT_PARSER_RET(pCmdHlp, pCmd, 0, cArgs >= 2);
     DBGC_CMDHLP_ASSERT_PARSER_RET(pCmdHlp, pCmd, 0, DBGCVAR_ISPOINTER(paArgs[0].enmType));
-    for (iArg = 1; iArg < cArgs; iArg++)
+    for (unsigned iArg = 1; iArg < cArgs; iArg++)
         DBGC_CMDHLP_ASSERT_PARSER_RET(pCmdHlp, pCmd, 0, paArgs[iArg].enmType == DBGCVAR_TYPE_NUMBER);
     DBGC_CMDHLP_REQ_UVM_RET(pCmdHlp, pCmd, pUVM);
@@ -4054 +4045 @@
      */
     DBGCVAR Addr = paArgs[0];
-    for (iArg = 1;;)
+    for (unsigned iArg = 1;;)
     {
         size_t cbWritten;
@@ -4288 +4279 @@
 static DECLCALLBACK(int) dbgcCmdSearchMem(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
+    RT_NOREF2(pCmd, paArgs);
+
     /* check that the parser did what it's supposed to do. */
     //if (    cArgs <= 2
@@ -4693 +4686 @@
 static DECLCALLBACK(int) dbgcCmdEventCtrlReset(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
+    RT_NOREF1(pCmd);
     uint32_t            cEventCfgs = 0;
     DBGFEVENTCONFIG     aEventCfgs[DBGFEVENT_END];
@@ -4808 +4802 @@
 static void dbgcEventDisplay(PDBGCCMDHLP pCmdHlp, const char *pszName, DBGCEVTSTATE enmDefault, PDBGCEVTCFG const *ppEvtCfg)
 {
+    RT_NOREF1(enmDefault);
     PDBGCEVTCFG pEvtCfg = *ppEvtCfg;
 
@@ -4877 +4872 @@
 static DECLCALLBACK(int) dbgcCmdEventCtrlList(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PUVM pUVM, PCDBGCVAR paArgs, unsigned cArgs)
 {
+    RT_NOREF2(pCmd, pUVM);
     PDBGC pDbgc = DBGC_CMDHLP2DBGC(pCmdHlp);
 
@@ -5193 +5189 @@
                                         PDBGCVAR pResult)
 {
+    RT_NOREF1(pUVM);
     AssertReturn(cArgs == 1, VERR_DBGC_PARSE_BUG);
     AssertReturn(DBGCVAR_ISPOINTER(paArgs[0].enmType), VERR_DBGC_PARSE_BUG);
@@ -5214 +5211 @@
                                          PDBGCVAR pResult)
 {
+    RT_NOREF1(pUVM);
     AssertReturn(cArgs == 1, VERR_DBGC_PARSE_BUG);
     AssertReturn(DBGCVAR_ISPOINTER(paArgs[0].enmType), VERR_DBGC_PARSE_BUG);
@@ -5235 +5233 @@
                                          PDBGCVAR pResult)
 {
+    RT_NOREF1(pUVM);
     AssertReturn(cArgs == 1, VERR_DBGC_PARSE_BUG);
     AssertReturn(DBGCVAR_ISPOINTER(paArgs[0].enmType), VERR_DBGC_PARSE_BUG);
@@ -5256 +5255 @@
                                          PDBGCVAR pResult)
 {
+    RT_NOREF1(pUVM);
     AssertReturn(cArgs == 1, VERR_DBGC_PARSE_BUG);
     AssertReturn(DBGCVAR_ISPOINTER(paArgs[0].enmType), VERR_DBGC_PARSE_BUG);

trunk/src/VBox/Debugger/DBGCEval.cpp

@@ -420 +420 @@
                            DBGCVARCAT enmCategory, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCategory);
+
     /*
      * Lookup the function.
@@ -1054 +1056 @@
                                 char *pszArgs, unsigned *piArg, unsigned *pcArgs)
 {
+    RT_NOREF1(pszCmdOrFunc);
     Log2(("dbgcProcessArguments: pszCmdOrFunc=%s pszArgs='%s'\n", pszCmdOrFunc, pszArgs));
 

trunk/src/VBox/Debugger/DBGCOps.cpp

@@ -241 +241 @@
 static DECLCALLBACK(int) dbgcOpMinus(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpMinus\n"));
     *pResult = *pArg;
@@ -279 +280 @@
 static DECLCALLBACK(int) dbgcOpPluss(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpPluss\n"));
     *pResult = *pArg;
@@ -306 +308 @@
 static DECLCALLBACK(int) dbgcOpBooleanNot(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpBooleanNot\n"));
     *pResult = *pArg;
@@ -348 +351 @@
 static DECLCALLBACK(int) dbgcOpBitwiseNot(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpBitwiseNot\n"));
     *pResult = *pArg;
@@ -386 +390 @@
 static DECLCALLBACK(int) dbgcOpVar(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpVar: %s\n", pArg->u.pszString));
     AssertReturn(pArg->enmType == DBGCVAR_TYPE_SYMBOL, VERR_DBGC_PARSE_BUG);
@@ -493 +498 @@
 DECLCALLBACK(int) dbgcOpAddrFlat(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpAddrFlat\n"));
     DBGCVARTYPE enmType = DBGCVAR_ISHCPOINTER(pArg->enmType) ? DBGCVAR_TYPE_HC_FLAT : DBGCVAR_TYPE_GC_FLAT;
@@ -504 +510 @@
 DECLCALLBACK(int) dbgcOpAddrPhys(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpAddrPhys\n"));
     DBGCVARTYPE enmType = DBGCVAR_ISHCPOINTER(pArg->enmType) ? DBGCVAR_TYPE_HC_PHYS : DBGCVAR_TYPE_GC_PHYS;
@@ -515 +522 @@
 DECLCALLBACK(int) dbgcOpAddrHostPhys(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpAddrPhys\n"));
     return DBGCCmdHlpConvert(&pDbgc->CmdHlp, pArg, DBGCVAR_TYPE_HC_PHYS, true /*fConvSyms*/, pResult);
@@ -525 +533 @@
 DECLCALLBACK(int) dbgcOpAddrHost(PDBGC pDbgc, PCDBGCVAR pArg, DBGCVARCAT enmCat, PDBGCVAR pResult)
 {
+    RT_NOREF1(enmCat);
     LogFlow(("dbgcOpAddrHost\n"));
     return DBGCCmdHlpConvert(&pDbgc->CmdHlp, pArg, DBGCVAR_TYPE_HC_FLAT, true /*fConvSyms*/, pResult);

trunk/src/VBox/Debugger/DBGCTcp.cpp

@@ -279 +279 @@
 DBGDECL(int) DBGCTcpTerminate(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
+
     /*
      * Destroy the server instance if any.

trunk/src/VBox/Debugger/DBGPlugInDarwin.cpp

@@ -137 +137 @@
                                                              char *pszBuf, size_t cbBuf, size_t *pcbActual)
 {
+    RT_NOREF1(fFlags);
     PDBGDIGGERDARWIN pData = RT_FROM_MEMBER(pThis, DBGDIGGERDARWIN, IDmesg);
 
@@ -307 +308 @@
 static DECLCALLBACK(void *) dbgDiggerDarwinQueryInterface(PUVM pUVM, void *pvData, DBGFOSINTERFACE enmIf)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERDARWIN pThis = (PDBGDIGGERDARWIN)pvData;
     switch (enmIf)
@@ -352 +354 @@
 static DECLCALLBACK(void)  dbgDiggerDarwinTerm(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERDARWIN pThis = (PDBGDIGGERDARWIN)pvData;
 
@@ -412 +415 @@
 static int dbgDiggerDarwinAddModule(PDBGDIGGERDARWIN pThis, PUVM pUVM, uint64_t uModAddr, const char *pszName, bool *pf64Bit)
 {
+    RT_NOREF1(pThis);
     union
     {
@@ -603 +607 @@
     if (hAs != NIL_RTDBGAS)
     {
-        uint64_t uRvaNext = 0;
+        //uint64_t uRvaNext = 0; - what was this?
         uint32_t cLinked  = 0;
         iSeg = cSegs;
@@ -945 +949 @@
 static DECLCALLBACK(void)  dbgDiggerDarwinDestruct(PUVM pUVM, void *pvData)
 {
+    RT_NOREF2(pUVM, pvData);
 
 }
@@ -954 +959 @@
 static DECLCALLBACK(int)  dbgDiggerDarwinConstruct(PUVM pUVM, void *pvData)
 {
+    RT_NOREF1(pUVM);
     PDBGDIGGERDARWIN pThis = (PDBGDIGGERDARWIN)pvData;